Merge pull request #14 from mmckeen-nv/codex/gateway-overrides-quick-deploy

[codex] Add gateway overrides and quick sandbox deploy
This commit is contained in:
mmckeen-nv
2026-05-04 09:24:51 -06:00
committed by GitHub
20 changed files with 747 additions and 145 deletions
+8
View File
@@ -7,6 +7,14 @@ NEXT_PUBLIC_KUBERNETES_NAMESPACE=agent-sandbox-system
# Docker container name running OpenShell # Docker container name running OpenShell
OPEN_SHELL_CONTAINER=openshell-cluster-openshell OPEN_SHELL_CONTAINER=openshell-cluster-openshell
# OpenShell gateway name used by CLI commands
OPENSHELL_GATEWAY=nemoclaw
# Optional gateway address override for containerized OpenShell/NemoClaw CLIs
# OPENSHELL_GATEWAY_HOST=host.docker.internal
# OPENSHELL_GATEWAY_PORT=8080
# OPENSHELL_GATEWAY_URL=http://host.docker.internal:8080
# Dashboard port # Dashboard port
NEXT_PUBLIC_DASHBOARD_PORT=3000 NEXT_PUBLIC_DASHBOARD_PORT=3000
+12
View File
@@ -307,6 +307,10 @@ NEXT_PUBLIC_API_BASE=/api
NEXT_PUBLIC_ENABLE_SANDBOX_OPERATIONS=true NEXT_PUBLIC_ENABLE_SANDBOX_OPERATIONS=true
OPEN_SHELL_CONTAINER=openshell-cluster-nemoclaw OPEN_SHELL_CONTAINER=openshell-cluster-nemoclaw
OPENSHELL_GATEWAY=nemoclaw OPENSHELL_GATEWAY=nemoclaw
# For containerized CLI runs, when supported by the installed OpenShell/NemoClaw versions:
# OPENSHELL_GATEWAY_HOST=host.docker.internal
# OPENSHELL_GATEWAY_PORT=8080
# OPENSHELL_GATEWAY_URL=http://host.docker.internal:8080
OPENSHELL_CONTROL_PASSWORD=change-this-password OPENSHELL_CONTROL_PASSWORD=change-this-password
OPENSHELL_CONTROL_AUTH_SECRET=change-this-random-secret OPENSHELL_CONTROL_AUTH_SECRET=change-this-random-secret
OPENSHELL_CONTROL_RECOVERY_TOKEN=change-this-recovery-token OPENSHELL_CONTROL_RECOVERY_TOKEN=change-this-recovery-token
@@ -314,6 +318,14 @@ MCP_BROKER_TOKEN_TTL_HOURS=168
MCP_BROKER_REQUEST_TIMEOUT_MS=45000 MCP_BROKER_REQUEST_TIMEOUT_MS=45000
``` ```
The controller also accepts an OpenShell config-file form at `~/.config/openshell/gateway.json` or `~/.config/openshell/config.json`:
```json
{ "gateway": { "host": "host.docker.internal", "port": 8080 } }
```
Those values are translated into `OPENSHELL_GATEWAY_HOST`, `OPENSHELL_GATEWAY_PORT`, and `OPENSHELL_GATEWAY_URL` for controller-launched OpenShell/NemoClaw child processes.
## Security Limitations ## Security Limitations
This is not production hardened. This is not production hardened.
+37 -8
View File
@@ -160,20 +160,49 @@ function bootstrapScriptResponse(proxyPrefix: string) {
try { try {
const protocol = window.location.protocol === 'https:' ? 'wss:' : 'ws:'; const protocol = window.location.protocol === 'https:' ? 'wss:' : 'ws:';
const gatewayHost = wsProxyPort ? window.location.hostname + ':' + wsProxyPort : window.location.host; const pageGatewayUrl = protocol + '//' + window.location.host + proxyPrefix;
const gatewayUrl = protocol + '//' + gatewayHost + proxyPrefix; const sidecarHost = wsProxyPort ? window.location.hostname + ':' + wsProxyPort : window.location.host;
const sidecarGatewayUrl = protocol + '//' + sidecarHost + proxyPrefix;
const settingsKey = 'openclaw.control.settings.v1'; const settingsKey = 'openclaw.control.settings.v1';
const settingsPrefix = 'openclaw.control.settings.v1:';
const tokenKey = 'openclaw.control.token.v1';
const tokenPrefix = 'openclaw.control.token.v1:'; const tokenPrefix = 'openclaw.control.token.v1:';
const tokenScope = gatewayUrl;
const hashParams = new URLSearchParams(window.location.hash.startsWith('#') ? window.location.hash.slice(1) : window.location.hash); const hashParams = new URLSearchParams(window.location.hash.startsWith('#') ? window.location.hash.slice(1) : window.location.hash);
const gatewayUrl = (hashParams.get('gatewayUrl') || '').trim() || sidecarGatewayUrl;
const token = (hashParams.get('token') || '').trim(); const token = (hashParams.get('token') || '').trim();
const rawSettings = window.localStorage.getItem(settingsKey); const storageScope = (value) => {
const settings = rawSettings ? JSON.parse(rawSettings) : {}; try {
const parsed = new URL(value, window.location.href);
const path = parsed.pathname === '/' ? '' : parsed.pathname.replace(/\\/+$/, '') || parsed.pathname;
return parsed.protocol + '//' + parsed.host + path;
} catch {
return value;
}
};
const uniqueScopes = (values) => Array.from(new Set(values.map(storageScope).filter(Boolean)));
const gatewayScopes = uniqueScopes([gatewayUrl, sidecarGatewayUrl, pageGatewayUrl]);
const settingsKeys = gatewayScopes.map((scope) => settingsPrefix + scope);
const readSettings = () => {
for (const key of [...settingsKeys, settingsPrefix + 'default', settingsKey]) {
try {
const raw = window.localStorage.getItem(key);
if (!raw) continue;
const parsed = JSON.parse(raw);
if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) return parsed;
} catch {}
}
return {};
};
const settings = readSettings();
settings.gatewayUrl = gatewayUrl; settings.gatewayUrl = gatewayUrl;
window.localStorage.setItem(settingsKey, JSON.stringify(settings)); const serializedSettings = JSON.stringify(settings);
window.sessionStorage.removeItem('openclaw.control.token.v1'); window.localStorage.setItem(settingsKey, serializedSettings);
if (token) window.sessionStorage.setItem(tokenPrefix + tokenScope, token); for (const key of settingsKeys) window.localStorage.setItem(key, serializedSettings);
window.sessionStorage.removeItem(tokenKey);
if (token) {
for (const scope of gatewayScopes) window.sessionStorage.setItem(tokenPrefix + scope, token);
}
} catch { } catch {
// Best-effort compatibility bridge for OpenClaw's persisted UI settings. // Best-effort compatibility bridge for OpenClaw's persisted UI settings.
} }
+417 -17
View File
@@ -1,7 +1,9 @@
import { NextResponse } from "next/server" import { NextResponse } from "next/server"
import { execFile, spawn } from "node:child_process" import { execFile, spawn } from "node:child_process"
import { existsSync, mkdirSync, readFileSync, renameSync, writeFileSync } from "node:fs"
import path from "node:path"
import { promisify } from "node:util" import { promisify } from "node:util"
import { inspectSandbox } from "@/app/lib/openshellHost" import { inspectSandbox, resolveSandboxRef } from "@/app/lib/openshellHost"
import { repairOpenClawExecApprovalsFile } from "@/app/lib/sandboxPrivilegedFiles" import { repairOpenClawExecApprovalsFile } from "@/app/lib/sandboxPrivilegedFiles"
import { import {
commandExists, commandExists,
@@ -13,9 +15,14 @@ import {
NEMOCLAW_SETUP_CANDIDATES, NEMOCLAW_SETUP_CANDIDATES,
NODE_BIN, NODE_BIN,
OPENSHELL_BIN, OPENSHELL_BIN,
hostCommandEnv,
} from "@/app/lib/hostCommands" } from "@/app/lib/hostCommands"
const execFileAsync = promisify(execFile) const execFileAsync = promisify(execFile)
const DOCKER_BIN = process.env.DOCKER_BIN || "docker"
const OPENSHELL_CLUSTER_CONTAINER = process.env.OPENSHELL_CLUSTER_CONTAINER || "openshell-cluster-nemoclaw"
const OPENSHELL_NAMESPACE = process.env.OPENSHELL_SANDBOX_NAMESPACE || "openshell"
const NEMOCLAW_REGISTRY_FILE = path.join(process.env.HOME || "/tmp", ".nemoclaw", "sandboxes.json")
function validateSandboxName(name: string) { function validateSandboxName(name: string) {
if (!name || typeof name !== "string") throw new Error("sandbox name is required") if (!name || typeof name !== "string") throw new Error("sandbox name is required")
@@ -67,6 +74,11 @@ type CreateInferenceSettings = {
envSummary: string[] envSummary: string[]
} }
type NemoClawRegistryData = {
sandboxes?: Record<string, { name?: string; createdAt?: string }>
defaultSandbox?: string | null
}
function parseCreateInferenceSettings(body: any): CreateInferenceSettings { function parseCreateInferenceSettings(body: any): CreateInferenceSettings {
const raw = body?.createInference && typeof body.createInference === "object" ? body.createInference : {} const raw = body?.createInference && typeof body.createInference === "object" ? body.createInference : {}
const requestedMode = typeof raw.mode === "string" ? raw.mode : "vllm" const requestedMode = typeof raw.mode === "string" ? raw.mode : "vllm"
@@ -127,6 +139,178 @@ function buildNemoClawCreateCommand(): NemoClawCreateCommand {
) )
} }
function resolveNemoClawBasePolicyPath() {
const home = process.env.HOME || ""
const candidates = [
process.env.NEMOCLAW_BASE_POLICY_PATH,
path.join(NEMOCLAW_CWD, "nemoclaw-blueprint", "policies", "openclaw-sandbox.yaml"),
home ? path.join(home, ".nemoclaw", "source", "nemoclaw-blueprint", "policies", "openclaw-sandbox.yaml") : undefined,
].filter((candidate): candidate is string => Boolean(candidate))
const found = candidates.find((candidate) => existsSync(candidate))
if (!found) {
throw new Error(`NemoClaw base policy was not found. Searched: ${candidates.join(", ")}`)
}
return found
}
async function readPodImage(sandboxName: string, jsonpath: string) {
const { stdout } = await execFileAsync(DOCKER_BIN, [
"exec",
OPENSHELL_CLUSTER_CONTAINER,
"kubectl",
"get",
"pod",
sandboxName,
"-n",
OPENSHELL_NAMESPACE,
"-o",
`jsonpath=${jsonpath}`,
], {
env: hostCommandEnv(),
timeout: 10000,
maxBuffer: 1024 * 1024,
})
return String(stdout).trim().split(/\s+/)[0] || null
}
function stripAnsi(value: string) {
return value.replace(/\u001b\[[0-9;]*m/g, "")
}
function parseOpenShellSandboxNames(output: string) {
return output
.split(/\r?\n/)
.map((entry) => stripAnsi(entry).trim())
.filter(
(entry) =>
entry &&
!/^name\s+/i.test(entry) &&
!/^[\s\-=]+$/.test(entry) &&
!/^no sandboxes found\.?$/i.test(entry)
)
.map((entry) => entry.split(/\s{2,}/)[0]?.trim())
.filter((entry): entry is string => Boolean(entry))
}
function readNemoClawRegistry(): NemoClawRegistryData {
try {
return existsSync(NEMOCLAW_REGISTRY_FILE)
? JSON.parse(readFileSync(NEMOCLAW_REGISTRY_FILE, "utf8"))
: {}
} catch {
return {}
}
}
async function listOpenShellSandboxNames() {
try {
const { stdout } = await execFileAsync(OPENSHELL_BIN, ["sandbox", "list"], {
env: hostCommandEnv({
OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw",
}),
timeout: 10000,
maxBuffer: 1024 * 1024,
})
return parseOpenShellSandboxNames(String(stdout))
} catch {
return []
}
}
async function resolveSourcePodImageFromRef(sourceSandboxRef: string) {
const requested = sourceSandboxRef.trim()
const source = await resolveSandboxRef(requested)
const sourceName = validateSandboxName(source.name)
const sourceImage = await readPodImage(sourceName, '{.spec.containers[?(@.name=="agent")].image}')
.catch(() => null)
|| await readPodImage(sourceName, "{.spec.containers[0].image}").catch(() => null)
if (!sourceImage) {
throw new Error(`Could not resolve the running image for source sandbox '${sourceName}'.`)
}
return {
requested,
name: sourceName,
id: source.id,
image: sourceImage,
}
}
async function resolveSourcePodImage(sourceSandboxRef: string | null | undefined, targetSandboxName: string) {
if (sourceSandboxRef && typeof sourceSandboxRef === "string" && sourceSandboxRef.trim()) {
return await resolveSourcePodImageFromRef(sourceSandboxRef)
}
const registry = readNemoClawRegistry()
const registeredEntries = Object.entries(registry.sandboxes ?? {})
const newestRegisteredNames = registeredEntries
.sort(([, a], [, b]) => String(b?.createdAt ?? "").localeCompare(String(a?.createdAt ?? "")))
.map(([key, value]) => value?.name || key)
const liveNames = await listOpenShellSandboxNames()
const candidates = Array.from(new Set([
registry.defaultSandbox || undefined,
...newestRegisteredNames,
...liveNames,
].filter((candidate): candidate is string => Boolean(candidate && candidate !== targetSandboxName))))
for (const candidate of candidates) {
try {
return await resolveSourcePodImageFromRef(candidate)
} catch {
// Try the next candidate; stale registry entries are common after manual cleanup.
}
}
throw new Error("No running NemoClaw sandbox image was found for quick deploy. Create one Fresh NemoClaw Image first, or pass sourceSandboxName explicitly.")
}
function registerNemoClawImageRedeploy(sourceName: string, sandboxName: string) {
try {
const current = existsSync(NEMOCLAW_REGISTRY_FILE)
? JSON.parse(readFileSync(NEMOCLAW_REGISTRY_FILE, "utf8"))
: {}
const sandboxes = current && typeof current.sandboxes === "object" && current.sandboxes !== null
? current.sandboxes
: {}
const sourceEntry = sandboxes[sourceName] && typeof sandboxes[sourceName] === "object"
? sandboxes[sourceName]
: { name: sourceName }
sandboxes[sandboxName] = {
...sourceEntry,
name: sandboxName,
createdAt: new Date().toISOString(),
nimContainer: null,
policies: [],
imageTag: null,
}
const next = {
...current,
sandboxes,
defaultSandbox: current.defaultSandbox || sandboxName,
}
mkdirSync(path.dirname(NEMOCLAW_REGISTRY_FILE), { recursive: true })
const tempPath = `${NEMOCLAW_REGISTRY_FILE}.tmp.${process.pid}.${Date.now()}`
writeFileSync(tempPath, `${JSON.stringify(next, null, 2)}\n`, { mode: 0o600 })
renameSync(tempPath, NEMOCLAW_REGISTRY_FILE)
return {
ok: true as const,
registryFile: NEMOCLAW_REGISTRY_FILE,
note: "Registered the image-redeployed sandbox in the local NemoClaw registry without assigning a host Docker image tag.",
}
} catch (error) {
return {
ok: false as const,
registryFile: NEMOCLAW_REGISTRY_FILE,
error: error instanceof Error ? error.message : "Failed to update the local NemoClaw registry",
}
}
}
async function verifySandboxCreation(sandboxName: string): Promise<SandboxVerification> { async function verifySandboxCreation(sandboxName: string): Promise<SandboxVerification> {
const startedAt = Date.now() const startedAt = Date.now()
console.log(`[sandbox/create] verify:start sandbox=${sandboxName}`) console.log(`[sandbox/create] verify:start sandbox=${sandboxName}`)
@@ -285,6 +469,131 @@ async function runCreateCommandBounded(file: string, args: string[], env: NodeJS
}) })
} }
async function runCreateCommandUntilReady(file: string, args: string[], env: NodeJS.ProcessEnv, sandboxName: string, timeoutMs: number, intervalMs: number) {
const startedAt = Date.now()
console.log(`[sandbox/create] ready-command:start file=${file} args=${JSON.stringify(args)} timeoutMs=${timeoutMs}`)
return await new Promise<{
completed: boolean
timedOut: boolean
forcedReady: boolean
exitCode: number | null
signal: NodeJS.Signals | null
stdout: string
stderr: string
error?: string
}>((resolve) => {
const child = spawn(file, args, {
env,
stdio: ["ignore", "pipe", "pipe"],
})
let stdout = ""
let stderr = ""
let settled = false
let checkingReady = false
const finish = (result: {
completed: boolean
timedOut: boolean
forcedReady: boolean
exitCode: number | null
signal: NodeJS.Signals | null
stdout: string
stderr: string
error?: string
}) => {
if (settled) return
settled = true
clearTimeout(timer)
clearInterval(readinessTimer)
resolve(result)
}
child.stdout?.on("data", (chunk) => {
stdout += String(chunk)
})
child.stderr?.on("data", (chunk) => {
stderr += String(chunk)
})
child.on("error", (error) => {
const message = error instanceof Error ? error.message : String(error ?? "Command failed")
console.log(`[sandbox/create] ready-command:error file=${file} elapsedMs=${elapsedMs(startedAt)} message=${message}`)
finish({
completed: false,
timedOut: false,
forcedReady: false,
exitCode: null,
signal: null,
stdout: stdout.trim(),
stderr: stderr.trim(),
error: message,
})
})
child.on("close", (code, signal) => {
console.log(`[sandbox/create] ready-command:close file=${file} elapsedMs=${elapsedMs(startedAt)} code=${code} signal=${signal} stdoutBytes=${stdout.length} stderrBytes=${stderr.length}`)
finish({
completed: true,
timedOut: false,
forcedReady: false,
exitCode: code,
signal,
stdout: stdout.trim(),
stderr: stderr.trim(),
...(code === 0 ? {} : { error: `Command exited with code ${code}${signal ? ` signal ${signal}` : ""}` }),
})
})
const readinessTimer = setInterval(() => {
if (settled || checkingReady) return
checkingReady = true
verifySandboxCreation(sandboxName)
.then((verification) => {
if (!settled && verification.verified) {
console.log(`[sandbox/create] ready-command:ready sandbox=${sandboxName} elapsedMs=${elapsedMs(startedAt)} sending=SIGTERM`)
child.kill("SIGTERM")
finish({
completed: false,
timedOut: false,
forcedReady: true,
exitCode: null,
signal: "SIGTERM",
stdout: stdout.trim(),
stderr: stderr.trim(),
})
}
})
.finally(() => {
checkingReady = false
})
}, intervalMs)
const timer = setTimeout(() => {
console.log(`[sandbox/create] ready-command:timeout file=${file} elapsedMs=${elapsedMs(startedAt)} sending=SIGTERM`)
child.kill("SIGTERM")
setTimeout(() => {
if (!settled) {
console.log(`[sandbox/create] ready-command:timeout-escalate file=${file} elapsedMs=${elapsedMs(startedAt)} sending=SIGKILL`)
child.kill("SIGKILL")
}
}, 2000)
finish({
completed: false,
timedOut: true,
forcedReady: false,
exitCode: null,
signal: "SIGTERM",
stdout: stdout.trim(),
stderr: stderr.trim(),
error: `Command exceeded timeout of ${timeoutMs}ms`,
})
}, timeoutMs)
})
}
async function approveOpenClawDeviceRequests(sandboxName: string) { async function approveOpenClawDeviceRequests(sandboxName: string) {
const result = await runCreateCommandBounded(OPENSHELL_BIN, [ const result = await runCreateCommandBounded(OPENSHELL_BIN, [
"sandbox", "sandbox",
@@ -295,14 +604,9 @@ async function approveOpenClawDeviceRequests(sandboxName: string) {
"sh", "sh",
"-lc", "-lc",
"openclaw devices approve --latest --json --timeout 10000", "openclaw devices approve --latest --json --timeout 10000",
], { ], hostCommandEnv({
...process.env,
PATH: HOST_PATH,
OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw", OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw",
NO_COLOR: "1", }), 15000)
CLICOLOR: "0",
CLICOLOR_FORCE: "0",
}, 15000)
const combinedOutput = `${result.stdout}\n${result.stderr}`.trim() const combinedOutput = `${result.stdout}\n${result.stderr}`.trim()
const noPending = NO_PENDING_DEVICE_REQUESTS.test(combinedOutput) const noPending = NO_PENDING_DEVICE_REQUESTS.test(combinedOutput)
@@ -359,7 +663,7 @@ export async function GET() {
blueprints: [ blueprints: [
{ {
id: "nemoclaw-blueprint", id: "nemoclaw-blueprint",
label: "New NemoClaw Sandbox", label: "Fresh NemoClaw Image",
description: "Bootstraps a full NemoClaw sandbox using the nemoclaw-blueprint workflow.", description: "Bootstraps a full NemoClaw sandbox using the nemoclaw-blueprint workflow.",
type: "blueprint", type: "blueprint",
source: "~/NemoClaw/nemoclaw-blueprint/blueprint.yaml", source: "~/NemoClaw/nemoclaw-blueprint/blueprint.yaml",
@@ -373,6 +677,14 @@ export async function GET() {
source: "dashboard-custom", source: "dashboard-custom",
supportsTailscale: false, supportsTailscale: false,
}, },
{
id: "redeploy-image",
label: "Quick Deploy New NemoClaw Sandbox",
description: "Create a default NemoClaw sandbox from the latest available running image without rebuilding it.",
type: "image",
source: "default-running-image",
supportsTailscale: false,
},
], ],
}) })
} }
@@ -395,15 +707,13 @@ export async function POST(request: Request) {
if (blueprint === "nemoclaw-blueprint") { if (blueprint === "nemoclaw-blueprint") {
const createCommand = buildNemoClawCreateCommand() const createCommand = buildNemoClawCreateCommand()
const env: NodeJS.ProcessEnv = { const env: NodeJS.ProcessEnv = hostCommandEnv({
...process.env,
PATH: HOST_PATH,
NEMOCLAW_SANDBOX_NAME: sandboxName, NEMOCLAW_SANDBOX_NAME: sandboxName,
NEMOCLAW_NON_INTERACTIVE: "1", NEMOCLAW_NON_INTERACTIVE: "1",
NEMOCLAW_RECREATE_SANDBOX: "1", NEMOCLAW_RECREATE_SANDBOX: "1",
NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE: "1", NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE: "1",
OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw", OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw",
} })
if (!enableTailscale) { if (!enableTailscale) {
env.NVIDIA_API_KEY = env.NVIDIA_API_KEY || "optional-local-mode" env.NVIDIA_API_KEY = env.NVIDIA_API_KEY || "optional-local-mode"
@@ -482,13 +792,12 @@ export async function POST(request: Request) {
} }
if (blueprint === "custom-sandbox") { if (blueprint === "custom-sandbox") {
const env: NodeJS.ProcessEnv = { const env: NodeJS.ProcessEnv = hostCommandEnv({
...process.env, OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw",
PATH: HOST_PATH,
NO_COLOR: "1", NO_COLOR: "1",
CLICOLOR: "0", CLICOLOR: "0",
CLICOLOR_FORCE: "0", CLICOLOR_FORCE: "0",
} })
const createAttempt = await runCreateCommandBounded(OPENSHELL_BIN, ["sandbox", "create", "--name", sandboxName], env, 15000) const createAttempt = await runCreateCommandBounded(OPENSHELL_BIN, ["sandbox", "create", "--name", sandboxName], env, 15000)
if (createAttempt.completed && createAttempt.exitCode !== 0) { if (createAttempt.completed && createAttempt.exitCode !== 0) {
@@ -558,6 +867,97 @@ export async function POST(request: Request) {
}, { status: created ? 200 : 502 }) }, { status: created ? 200 : 502 })
} }
if (blueprint === "redeploy-image") {
const sourceSandboxName = typeof body?.sourceSandboxName === "string" ? body.sourceSandboxName.trim() : ""
const source = await resolveSourcePodImage(sourceSandboxName, sandboxName)
const sourceImage = source.image
const basePolicyPath = resolveNemoClawBasePolicyPath()
const env: NodeJS.ProcessEnv = hostCommandEnv({
OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw",
})
const createAttempt = await runCreateCommandUntilReady(OPENSHELL_BIN, [
"sandbox",
"create",
"--name",
sandboxName,
"--from",
sourceImage,
"--policy",
basePolicyPath,
"--auto-providers",
"--",
"nemoclaw-start",
], env, sandboxName, 120000, 2000)
const readiness = await waitForSandboxReady(sandboxName, 90000, 2000)
const verification = readiness.verification ?? {
verified: false,
summary: "Sandbox readiness polling produced no verification result.",
error: "Sandbox readiness polling produced no verification result.",
}
const created = readiness.verified
const registry = created ? registerNemoClawImageRedeploy(source.name, sandboxName) : null
const execApprovalsRepair = created ? await repairOpenClawExecApprovalsFile(sandboxName).catch((error) => ({
sandboxName,
path: "/sandbox/.openclaw/exec-approvals.json",
error: error instanceof Error ? error.message : "Failed to repair OpenClaw exec approvals file",
})) : null
const deviceApproval = created ? await approveOpenClawDeviceRequests(sandboxName) : null
console.log(
`[sandbox/create] request:complete sandbox=${sandboxName} created=${created} mode=redeploy-image createTimedOut=${createAttempt.timedOut} readinessAttempts=${readiness.attempts} deviceApproval=${deviceApproval?.approved ?? false} elapsedMs=${elapsedMs(requestStartedAt)}`,
)
const createFailed = createAttempt.completed && createAttempt.exitCode !== 0 && !created
return NextResponse.json({
ok: created,
blueprint,
sandboxName,
sourceSandboxName: source.name,
sourceSandboxId: source.id,
sourceImage,
basePolicyPath,
created,
verified: verification.verified,
verification,
mode: "redeploy-image",
stdout: createAttempt.stdout,
stderr: createAttempt.stderr,
createCommand: {
completed: createAttempt.completed,
timedOut: createAttempt.timedOut,
forcedReady: createAttempt.forcedReady,
exitCode: createAttempt.exitCode,
signal: createAttempt.signal,
error: createAttempt.error,
},
readiness: {
attempts: readiness.attempts,
elapsedMs: readiness.elapsedMs,
},
registry,
execApprovalsRepair,
deviceApproval,
note: created
? appendNote(
`Sandbox created by redeploying the running image from '${source.name}' instead of rebuilding it.`,
createAttempt.forcedReady
? "The dashboard returned as soon as OpenShell reported the redeployed sandbox Ready."
: false,
createAttempt.timedOut
? "The OpenShell create command stayed attached after the sandbox reached Ready, so the dashboard stopped waiting for the local command."
: false,
registry && !registry.ok ? `NemoClaw registry update failed: ${registry.error}` : false,
execApprovalsRepair && "note" in execApprovalsRepair ? execApprovalsRepair.note : false,
execApprovalsRepair && "error" in execApprovalsRepair ? `OpenClaw exec approvals repair failed: ${execApprovalsRepair.error}` : false,
deviceApproval?.note,
)
: createFailed
? "Image redeploy command failed and the sandbox never reached a ready verification state afterward."
: "Image redeploy started, but the sandbox never reached a ready verification state afterward.",
}, { status: created ? 200 : createFailed ? 500 : 502 })
}
return NextResponse.json({ ok: false, error: `unknown blueprint: ${blueprint}` }, { status: 400 }) return NextResponse.json({ ok: false, error: `unknown blueprint: ${blueprint}` }, { status: 400 })
} catch (error) { } catch (error) {
const message = error instanceof Error ? error.message : "Sandbox creation failed" const message = error instanceof Error ? error.message : "Sandbox creation failed"
+6 -78
View File
@@ -2,7 +2,7 @@ import { NextResponse } from "next/server"
import { execFile } from "node:child_process" import { execFile } from "node:child_process"
import { promisify } from "node:util" import { promisify } from "node:util"
import { resolveSandboxRef } from "@/app/lib/openshellHost" import { resolveSandboxRef } from "@/app/lib/openshellHost"
import { HOST_PATH, NEMOCLAW_BIN, NEMOCLAW_CWD, OPENSHELL_BIN } from "@/app/lib/hostCommands" import { OPENSHELL_BIN, hostCommandEnv } from "@/app/lib/hostCommands"
const execFileAsync = promisify(execFile) const execFileAsync = promisify(execFile)
@@ -54,14 +54,9 @@ async function deleteSandbox(sandboxName: string) {
console.log(`[sandbox/delete] command:start sandbox=${sandboxName}`) console.log(`[sandbox/delete] command:start sandbox=${sandboxName}`)
try { try {
const { stdout, stderr } = await execFileAsync(OPENSHELL_BIN, ["sandbox", "delete", sandboxName], { const { stdout, stderr } = await execFileAsync(OPENSHELL_BIN, ["sandbox", "delete", sandboxName], {
env: { env: hostCommandEnv({
...process.env,
PATH: HOST_PATH,
OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw", OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw",
NO_COLOR: "1", }),
CLICOLOR: "0",
CLICOLOR_FORCE: "0",
},
timeout: 60000, timeout: 60000,
maxBuffer: 20 * 1024 * 1024, maxBuffer: 20 * 1024 * 1024,
}) })
@@ -83,53 +78,6 @@ function isSandboxNotFound(output: string) {
return /sandbox not found|status:\s*NotFound|not present in the live OpenShell gateway/i.test(output) return /sandbox not found|status:\s*NotFound|not present in the live OpenShell gateway/i.test(output)
} }
function isNemoClawSandboxNotRegistered(output: string, sandboxName: string) {
return new RegExp(`Unknown command:\\s*${sandboxName.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}`, "i").test(output)
}
async function cleanupNemoClawSandbox(sandboxName: string) {
const startedAt = Date.now()
console.log(`[sandbox/delete] nemoclaw-cleanup:start sandbox=${sandboxName}`)
try {
const { stdout, stderr } = await execFileAsync(NEMOCLAW_BIN, [sandboxName, "destroy", "--yes"], {
cwd: NEMOCLAW_CWD,
env: {
...process.env,
PATH: HOST_PATH,
OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw",
NO_COLOR: "1",
CLICOLOR: "0",
CLICOLOR_FORCE: "0",
},
timeout: 90000,
maxBuffer: 20 * 1024 * 1024,
})
console.log(`[sandbox/delete] nemoclaw-cleanup:done sandbox=${sandboxName} elapsedMs=${elapsedMs(startedAt)}`)
return { ok: true as const, stdout: String(stdout).trim(), stderr: String(stderr).trim() }
} catch (error: any) {
const message = error instanceof Error ? error.message : String(error ?? "NemoClaw cleanup failed")
const stdout = String(error?.stdout || "").trim()
const stderr = String(error?.stderr || "").trim()
const output = [message, stdout, stderr].filter(Boolean).join("\n")
if (isNemoClawSandboxNotRegistered(output, sandboxName)) {
console.log(`[sandbox/delete] nemoclaw-cleanup:already-gone sandbox=${sandboxName} elapsedMs=${elapsedMs(startedAt)}`)
return {
ok: true as const,
stdout,
stderr,
note: "NemoClaw registry already had no matching sandbox.",
}
}
console.log(`[sandbox/delete] nemoclaw-cleanup:error sandbox=${sandboxName} elapsedMs=${elapsedMs(startedAt)} message=${message}`)
return {
ok: false as const,
stdout,
stderr,
error: message,
}
}
}
async function waitForSandboxDeleted(sandboxName: string, timeoutMs: number, intervalMs: number) { async function waitForSandboxDeleted(sandboxName: string, timeoutMs: number, intervalMs: number) {
const startedAt = Date.now() const startedAt = Date.now()
let attempts = 0 let attempts = 0
@@ -179,7 +127,6 @@ export async function POST(request: Request) {
const result = await deleteSandbox(target.sandboxName) const result = await deleteSandbox(target.sandboxName)
const deleteOutput = [result.error, result.stdout, result.stderr].filter(Boolean).join("\n") const deleteOutput = [result.error, result.stdout, result.stderr].filter(Boolean).join("\n")
const openShellAlreadyGone = !result.ok && isSandboxNotFound(deleteOutput) const openShellAlreadyGone = !result.ok && isSandboxNotFound(deleteOutput)
const cleanup = await cleanupNemoClawSandbox(target.sandboxName)
if (!result.ok && !openShellAlreadyGone) { if (!result.ok && !openShellAlreadyGone) {
return NextResponse.json({ return NextResponse.json({
@@ -193,24 +140,6 @@ export async function POST(request: Request) {
error: result.error, error: result.error,
stdout: result.stdout, stdout: result.stdout,
stderr: result.stderr, stderr: result.stderr,
nemoclaw: cleanup,
}, { status: 500 })
}
if (!cleanup.ok) {
return NextResponse.json({
ok: false,
deleted: false,
requested: target.requested,
sandboxName: target.sandboxName,
sandboxId: target.sandboxId,
resolved: target.resolved,
openShellAlreadyGone,
openShell: result,
error: cleanup.error,
stdout: cleanup.stdout,
stderr: cleanup.stderr,
nemoclaw: cleanup,
}, { status: 500 }) }, { status: 500 })
} }
@@ -224,13 +153,12 @@ export async function POST(request: Request) {
sandboxName: target.sandboxName, sandboxName: target.sandboxName,
sandboxId: target.sandboxId, sandboxId: target.sandboxId,
resolved: target.resolved, resolved: target.resolved,
stdout: [result.stdout, cleanup.stdout].filter(Boolean).join("\n\n"), stdout: result.stdout,
stderr: [result.stderr, cleanup.stderr].filter(Boolean).join("\n\n"), stderr: result.stderr,
openShellAlreadyGone, openShellAlreadyGone,
openShell: result, openShell: result,
nemoclaw: cleanup,
deletion, deletion,
note: deleted ? "Sandbox delete completed and NemoClaw registry cleanup ran." : "Sandbox delete command completed, but inventory still reports the sandbox.", note: deleted ? "Sandbox delete completed." : "Sandbox delete command completed, but inventory still reports the sandbox.",
}, { status: deleted ? 200 : 202 }) }, { status: deleted ? 200 : 202 })
} catch (error) { } catch (error) {
const message = error instanceof Error ? error.message : "Sandbox delete failed" const message = error instanceof Error ? error.message : "Sandbox delete failed"
+5 -2
View File
@@ -3,7 +3,7 @@ import { promisify } from "node:util"
import { NextResponse } from "next/server" import { NextResponse } from "next/server"
import { listActivity } from "@/app/lib/activityLog" import { listActivity } from "@/app/lib/activityLog"
import { listBackupCatalog } from "@/app/lib/backupCatalog" import { listBackupCatalog } from "@/app/lib/backupCatalog"
import { HOST_PATH, OPENSHELL_BIN } from "@/app/lib/hostCommands" import { HOST_PATH, OPENSHELL_BIN, hostCommandEnv } from "@/app/lib/hostCommands"
const execFileAsync = promisify(execFile) const execFileAsync = promisify(execFile)
@@ -11,9 +11,12 @@ export const dynamic = "force-dynamic"
async function run(command: string, args: string[]) { async function run(command: string, args: string[]) {
try { try {
const env = command === OPENSHELL_BIN
? hostCommandEnv({ OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw" })
: { ...process.env, PATH: HOST_PATH, NO_COLOR: "1", CLICOLOR: "0", CLICOLOR_FORCE: "0" }
const { stdout, stderr } = await execFileAsync(command, args, { const { stdout, stderr } = await execFileAsync(command, args, {
timeout: 10000, timeout: 10000,
env: { ...process.env, PATH: HOST_PATH, NO_COLOR: "1", CLICOLOR: "0", CLICOLOR_FORCE: "0" }, env,
}) })
return { ok: true, stdout: stdout.trim(), stderr: stderr.trim() } return { ok: true, stdout: stdout.trim(), stderr: stderr.trim() }
} catch (error) { } catch (error) {
+4 -8
View File
@@ -2,7 +2,7 @@ import { NextResponse } from "next/server"
import { execFile } from "node:child_process" import { execFile } from "node:child_process"
import { hostname, networkInterfaces } from "node:os" import { hostname, networkInterfaces } from "node:os"
import { promisify } from "node:util" import { promisify } from "node:util"
import { HOST_PATH, NEMOCLAW_BIN, NODE_BIN, OPENSHELL_BIN, hostCommandEnv } from "@/app/lib/hostCommands" import { NEMOCLAW_BIN, NODE_BIN, OPENSHELL_BIN, hostCommandEnv } from "@/app/lib/hostCommands"
import { resolveRuntimeAuthority } from "@/app/lib/runtimeAuthority" import { resolveRuntimeAuthority } from "@/app/lib/runtimeAuthority"
const execFileAsync = promisify(execFile) const execFileAsync = promisify(execFile)
@@ -146,13 +146,9 @@ function buildNemoClawSummary(output: string | null, defaultSandboxNames: Set<st
} }
async function execNemoclaw(args: string[]) { async function execNemoclaw(args: string[]) {
const env = { const env = hostCommandEnv({
...process.env, OPENSHELL_GATEWAY: process.env.OPENSHELL_GATEWAY || "nemoclaw",
PATH: HOST_PATH, })
NO_COLOR: "1",
CLICOLOR: "0",
CLICOLOR_FORCE: "0",
}
const command = /\.(?:c?m?js|ts)$/i.test(NEMOCLAW_BIN) const command = /\.(?:c?m?js|ts)$/i.test(NEMOCLAW_BIN)
? execFileAsync(NODE_BIN, [NEMOCLAW_BIN, ...args], { env }) ? execFileAsync(NODE_BIN, [NEMOCLAW_BIN, ...args], { env })
+11 -6
View File
@@ -19,7 +19,7 @@ type BlueprintOption = {
id: string id: string
label: string label: string
description: string description: string
type: "blueprint" | "custom" type: "blueprint" | "custom" | "image"
source: string source: string
supportsTailscale?: boolean supportsTailscale?: boolean
} }
@@ -85,7 +85,7 @@ export default function ConfigurationPanel({ sandboxId, mode = 'existing', onCre
const [message, setMessage] = useState("") const [message, setMessage] = useState("")
const [selectedPreset, setSelectedPreset] = useState<SecurityPresetId | ''>('') const [selectedPreset, setSelectedPreset] = useState<SecurityPresetId | ''>('')
const [blueprints, setBlueprints] = useState<BlueprintOption[]>([]) const [blueprints, setBlueprints] = useState<BlueprintOption[]>([])
const [selectedBlueprint, setSelectedBlueprint] = useState<string>('nemoclaw-blueprint') const [selectedBlueprint, setSelectedBlueprint] = useState<string>('redeploy-image')
const [sandboxName, setSandboxName] = useState<string>('') const [sandboxName, setSandboxName] = useState<string>('')
const [enableTailscale, setEnableTailscale] = useState<boolean>(false) const [enableTailscale, setEnableTailscale] = useState<boolean>(false)
const [createInferenceMode, setCreateInferenceMode] = useState<CreateInferenceMode>("vllm") const [createInferenceMode, setCreateInferenceMode] = useState<CreateInferenceMode>("vllm")
@@ -208,7 +208,7 @@ export default function ConfigurationPanel({ sandboxId, mode = 'existing', onCre
<button key={bp.id} type="button" onClick={() => setSelectedBlueprint(bp.id)} className={`rounded-sm border p-4 text-left ${selectedBlueprint === bp.id ? 'border-[var(--nvidia-green)] bg-[rgba(118,185,0,0.08)]' : 'border-[var(--border-subtle)] bg-[var(--background)]'}`}> <button key={bp.id} type="button" onClick={() => setSelectedBlueprint(bp.id)} className={`rounded-sm border p-4 text-left ${selectedBlueprint === bp.id ? 'border-[var(--nvidia-green)] bg-[rgba(118,185,0,0.08)]' : 'border-[var(--border-subtle)] bg-[var(--background)]'}`}>
<div className="flex items-center justify-between gap-3"> <div className="flex items-center justify-between gap-3">
<span className="text-sm font-semibold text-[var(--foreground)] uppercase tracking-wider">{bp.label}</span> <span className="text-sm font-semibold text-[var(--foreground)] uppercase tracking-wider">{bp.label}</span>
<Badge tone={bp.type === 'custom' ? 'static' : 'dynamic'}>{bp.type}</Badge> <Badge tone={bp.type === 'blueprint' ? 'dynamic' : 'static'}>{bp.type}</Badge>
</div> </div>
<p className="text-xs text-[var(--foreground-dim)] mt-2">{bp.description}</p> <p className="text-xs text-[var(--foreground-dim)] mt-2">{bp.description}</p>
</button> </button>
@@ -216,15 +216,20 @@ export default function ConfigurationPanel({ sandboxId, mode = 'existing', onCre
</div> </div>
<div> <div>
<label className="text-xs uppercase tracking-wider text-[var(--foreground-dim)]">Sandbox Name<FieldHelp text="Lowercase letters, numbers, and hyphens only." /></label> <label className="text-xs uppercase tracking-wider text-[var(--foreground-dim)]">Sandbox Name<FieldHelp text="Lowercase letters, numbers, and hyphens only." /></label>
<input value={sandboxName} onChange={(e) => setSandboxName(e.target.value)} placeholder={selectedBlueprint === 'nemoclaw-blueprint' ? 'my-assistant' : 'custom-sandbox'} className="mt-2 w-full rounded-sm border border-[var(--border-subtle)] bg-[var(--background)] px-3 py-2 text-xs font-mono text-[var(--foreground)]" /> <input value={sandboxName} onChange={(e) => setSandboxName(e.target.value)} placeholder={selectedBlueprint === 'nemoclaw-blueprint' ? 'my-assistant' : selectedBlueprint === 'redeploy-image' ? 'my-assistant-copy' : 'custom-sandbox'} className="mt-2 w-full rounded-sm border border-[var(--border-subtle)] bg-[var(--background)] px-3 py-2 text-xs font-mono text-[var(--foreground)]" />
</div> </div>
{selectedBlueprint === 'redeploy-image' && (
<div className="rounded-sm border border-[var(--border-subtle)] bg-[var(--background)] p-4">
<p className="text-xs text-[var(--foreground-dim)]">Quick Deploy uses the default running NemoClaw image and skips the Docker rebuild. Use Fresh NemoClaw Image when you need to rebuild the image layers.</p>
</div>
)}
{activeBlueprint?.supportsTailscale && ( {activeBlueprint?.supportsTailscale && (
<label className="flex items-center gap-3 text-sm text-[var(--foreground)] font-mono"> <label className="flex items-center gap-3 text-sm text-[var(--foreground)] font-mono">
<input type="checkbox" checked={enableTailscale} onChange={(e) => setEnableTailscale(e.target.checked)} /> Enable Tailscale <input type="checkbox" checked={enableTailscale} onChange={(e) => setEnableTailscale(e.target.checked)} /> Enable Tailscale
</label> </label>
)} )}
{enableTailscale && <div className="rounded-sm border border-amber-500/40 bg-amber-500/10 p-3 text-sm text-amber-300">Tailscale-enabled creation requires NVIDIA_API_KEY in the dashboard process environment.</div>} {enableTailscale && <div className="rounded-sm border border-amber-500/40 bg-amber-500/10 p-3 text-sm text-amber-300">Tailscale-enabled creation requires NVIDIA_API_KEY in the dashboard process environment.</div>}
<div className="rounded-sm border border-[var(--border-subtle)] bg-[var(--background)] p-4 space-y-4"> {selectedBlueprint === 'nemoclaw-blueprint' && <div className="rounded-sm border border-[var(--border-subtle)] bg-[var(--background)] p-4 space-y-4">
<div> <div>
<h6 className="text-xs font-semibold uppercase tracking-wider text-[var(--foreground)]">Inference at Create</h6> <h6 className="text-xs font-semibold uppercase tracking-wider text-[var(--foreground)]">Inference at Create</h6>
<p className="mt-1 text-xs text-[var(--foreground-dim)]">Choose the provider NemoClaw should use while onboarding this sandbox.</p> <p className="mt-1 text-xs text-[var(--foreground-dim)]">Choose the provider NemoClaw should use while onboarding this sandbox.</p>
@@ -257,7 +262,7 @@ export default function ConfigurationPanel({ sandboxId, mode = 'existing', onCre
)} )}
</div> </div>
)} )}
</div> </div>}
<div className="rounded-sm border border-[var(--border-subtle)] bg-[var(--background)] p-4 space-y-4"> <div className="rounded-sm border border-[var(--border-subtle)] bg-[var(--background)] p-4 space-y-4">
<label className="flex items-start gap-3"> <label className="flex items-start gap-3">
<input type="checkbox" checked={restoreFromBackup} onChange={(e) => setRestoreFromBackup(e.target.checked)} className="mt-0.5 h-4 w-4 accent-[var(--nvidia-green)]" /> <input type="checkbox" checked={restoreFromBackup} onChange={(e) => setRestoreFromBackup(e.target.checked)} className="mt-0.5 h-4 w-4 accent-[var(--nvidia-green)]" />
+8 -6
View File
@@ -7,6 +7,7 @@ type BlueprintOption = {
id: string id: string
label: string label: string
description: string description: string
type?: "blueprint" | "custom" | "image"
supportsTailscale?: boolean supportsTailscale?: boolean
} }
@@ -64,7 +65,7 @@ export default function WizardPanel({
const [sourceSandboxId, setSourceSandboxId] = useState("") const [sourceSandboxId, setSourceSandboxId] = useState("")
const [targetName, setTargetName] = useState("") const [targetName, setTargetName] = useState("")
const [blueprints, setBlueprints] = useState<BlueprintOption[]>([]) const [blueprints, setBlueprints] = useState<BlueprintOption[]>([])
const [selectedBlueprint, setSelectedBlueprint] = useState("custom-sandbox") const [selectedBlueprint, setSelectedBlueprint] = useState("redeploy-image")
const [enableTailscale, setEnableTailscale] = useState(false) const [enableTailscale, setEnableTailscale] = useState(false)
const [backupPath, setBackupPath] = useState("/sandbox") const [backupPath, setBackupPath] = useState("/sandbox")
const [restorePath, setRestorePath] = useState("/sandbox") const [restorePath, setRestorePath] = useState("/sandbox")
@@ -161,13 +162,14 @@ export default function WizardPanel({
setRunLog([]) setRunLog([])
setActiveStep("run") setActiveStep("run")
appendLog(`Creating target sandbox ${targetName}...`) appendLog(selectedBlueprint === "redeploy-image" ? `Redeploying ${sourceSandbox.name}'s image as ${targetName}...` : `Creating target sandbox ${targetName}...`)
const createResponse = await fetch("/api/sandbox/create", { const createResponse = await fetch("/api/sandbox/create", {
method: "POST", method: "POST",
headers: { "Content-Type": "application/json" }, headers: { "Content-Type": "application/json" },
body: JSON.stringify({ body: JSON.stringify({
blueprint: selectedBlueprint, blueprint: selectedBlueprint,
sandboxName: targetName.trim(), sandboxName: targetName.trim(),
sourceSandboxName: sourceSandbox.name,
enableTailscale, enableTailscale,
policy: null, policy: null,
preset: null, preset: null,
@@ -533,11 +535,11 @@ export default function WizardPanel({
</svg> </svg>
<div> <div>
<h2 className="text-sm font-semibold uppercase tracking-wider text-[var(--foreground)]">Clone Sandbox</h2> <h2 className="text-sm font-semibold uppercase tracking-wider text-[var(--foreground)]">Clone Sandbox</h2>
<p className="mt-1 text-xs text-[var(--foreground-dim)]">Create a fresh sandbox, back up the source, then restore into the target.</p> <p className="mt-1 text-xs text-[var(--foreground-dim)]">Start a fresh sandbox from the source image, then restore source files into the target.</p>
</div> </div>
</div> </div>
<span className="status-chip shrink-0 border border-[var(--border-subtle)] bg-[var(--background-tertiary)] px-2.5 py-1 text-[var(--foreground-dim)]"> <span className="status-chip shrink-0 border border-[var(--border-subtle)] bg-[var(--background-tertiary)] px-2.5 py-1 text-[var(--foreground-dim)]">
backup + restore image + restore
</span> </span>
</button> </button>
@@ -604,7 +606,7 @@ export default function WizardPanel({
<div className="space-y-4"> <div className="space-y-4">
<div> <div>
<h3 className="text-xs font-semibold uppercase tracking-wider text-[var(--foreground)]">Configure Target Sandbox</h3> <h3 className="text-xs font-semibold uppercase tracking-wider text-[var(--foreground)]">Configure Target Sandbox</h3>
<p className="mt-1 text-xs text-[var(--foreground-dim)]">Choose the sandbox blueprint and target name.</p> <p className="mt-1 text-xs text-[var(--foreground-dim)]">Choose how the target is created and set its sandbox name.</p>
</div> </div>
<div className="grid grid-cols-1 gap-4 md:grid-cols-2"> <div className="grid grid-cols-1 gap-4 md:grid-cols-2">
{blueprints.map((blueprint) => ( {blueprints.map((blueprint) => (
@@ -673,7 +675,7 @@ export default function WizardPanel({
{[ {[
["Source", sourceSandbox?.name || "-"], ["Source", sourceSandbox?.name || "-"],
["Target", targetName || "-"], ["Target", targetName || "-"],
["Blueprint", activeBlueprint?.label || selectedBlueprint], ["Create Path", activeBlueprint?.label || selectedBlueprint],
["Backup Path", backupPath], ["Backup Path", backupPath],
["Restore Path", restorePath], ["Restore Path", restorePath],
["Restore Mode", replaceTarget ? "replace" : "merge"], ["Restore Mode", replaceTarget ? "replace" : "merge"],
+62 -1
View File
@@ -1,4 +1,4 @@
import { existsSync, readdirSync, statSync } from "node:fs" import { existsSync, readFileSync, readdirSync, statSync } from "node:fs"
import path from "node:path" import path from "node:path"
const HOME = process.env.HOME || "" const HOME = process.env.HOME || ""
@@ -107,11 +107,72 @@ function pathEntries() {
export const HOST_PATH = unique(pathEntries()).join(":") export const HOST_PATH = unique(pathEntries()).join(":")
function nonEmptyEnv(name: string) {
const value = process.env[name]?.trim()
return value || undefined
}
function gatewayUrlFromHost(host: string, port: string) {
if (/^https?:\/\//i.test(host)) return host
if (host.includes(":")) return `http://${host}`
return `http://${host}:${port}`
}
function stringConfigValue(value: unknown) {
if (typeof value === "string") return value.trim() || undefined
if (typeof value === "number" && Number.isFinite(value)) return String(value)
return undefined
}
function readOpenShellGatewayAddressConfig() {
const configDir = OPENSHELL_XDG_CONFIG_HOME ? path.join(OPENSHELL_XDG_CONFIG_HOME, "openshell") : ""
const candidates = unique([
process.env.OPENSHELL_GATEWAY_CONFIG,
configDir ? path.join(configDir, "gateway.json") : undefined,
configDir ? path.join(configDir, "config.json") : undefined,
])
for (const candidate of candidates) {
if (!existsSync(candidate)) continue
try {
const parsed = JSON.parse(readFileSync(candidate, "utf8"))
const gateway = parsed?.gateway && typeof parsed.gateway === "object" ? parsed.gateway : {}
const host = stringConfigValue(parsed?.gatewayHost) || stringConfigValue(gateway.host)
const port = stringConfigValue(parsed?.gatewayPort) || stringConfigValue(gateway.port)
const url = stringConfigValue(parsed?.gatewayUrl) || stringConfigValue(gateway.url)
if (host || port || url) return { host, port, url }
} catch {
// Ignore malformed optional config; explicit env vars remain authoritative.
}
}
return {}
}
export function openshellGatewayAddressEnv() {
const config = readOpenShellGatewayAddressConfig()
const host = nonEmptyEnv("OPENSHELL_GATEWAY_HOST") || config.host
const configuredPort = nonEmptyEnv("OPENSHELL_GATEWAY_PORT") || config.port
const port = configuredPort || "8080"
const explicitUrl = nonEmptyEnv("OPENSHELL_GATEWAY_URL") || config.url
return {
...(host ? { OPENSHELL_GATEWAY_HOST: host } : {}),
...(configuredPort || host || explicitUrl ? { OPENSHELL_GATEWAY_PORT: port } : {}),
...(explicitUrl
? { OPENSHELL_GATEWAY_URL: explicitUrl }
: host
? { OPENSHELL_GATEWAY_URL: gatewayUrlFromHost(host, port) }
: {}),
}
}
export function hostCommandEnv(extra: Record<string, string | undefined> = {}) { export function hostCommandEnv(extra: Record<string, string | undefined> = {}) {
return { return {
...process.env, ...process.env,
...(OPENSHELL_HOME ? { HOME: OPENSHELL_HOME } : {}), ...(OPENSHELL_HOME ? { HOME: OPENSHELL_HOME } : {}),
...(OPENSHELL_XDG_CONFIG_HOME ? { XDG_CONFIG_HOME: OPENSHELL_XDG_CONFIG_HOME } : {}), ...(OPENSHELL_XDG_CONFIG_HOME ? { XDG_CONFIG_HOME: OPENSHELL_XDG_CONFIG_HOME } : {}),
...openshellGatewayAddressEnv(),
PATH: HOST_PATH, PATH: HOST_PATH,
NO_COLOR: "1", NO_COLOR: "1",
CLICOLOR: "0", CLICOLOR: "0",
+6 -1
View File
@@ -8,6 +8,10 @@ const execFileAsync = promisify(execFile)
const LOCAL_HOSTNAMES = new Set(["localhost", "127.0.0.1", "0.0.0.0", "host.docker.internal", "host.openshell.internal"]) const LOCAL_HOSTNAMES = new Set(["localhost", "127.0.0.1", "0.0.0.0", "host.docker.internal", "host.openshell.internal"])
const FALLBACK_SANDBOX_PROXY_ORIGIN = "http://10.200.0.1:3128" const FALLBACK_SANDBOX_PROXY_ORIGIN = "http://10.200.0.1:3128"
function shouldUseProxyWrappedBrokerUrl() {
return /^(1|true|yes|on)$/i.test(process.env.OPENSHELL_CONTROL_MCP_BROKER_PROXY_URL || "")
}
async function discoverOpenShellDockerGateway() { async function discoverOpenShellDockerGateway() {
const container = process.env.OPEN_SHELL_CONTAINER || "openshell-cluster-nemoclaw" const container = process.env.OPEN_SHELL_CONTAINER || "openshell-cluster-nemoclaw"
const { stdout } = await execFileAsync("docker", ["inspect", container], { const { stdout } = await execFileAsync("docker", ["inspect", container], {
@@ -67,10 +71,11 @@ export async function brokerBaseUrlForSandbox(
} }
const hostBrokerUrl = `${publicOrigin.toString().replace(/\/+$/, "")}/api/mcp/broker` const hostBrokerUrl = `${publicOrigin.toString().replace(/\/+$/, "")}/api/mcp/broker`
if (!shouldUseProxyWrappedBrokerUrl()) return hostBrokerUrl
const proxyOrigin = sandbox const proxyOrigin = sandbox
? await discoverSandboxProxyOrigin(sandbox.id, sandbox.name).catch(() => null) ? await discoverSandboxProxyOrigin(sandbox.id, sandbox.name).catch(() => null)
: null : null
if (proxyOrigin) return `${proxyOrigin}/${hostBrokerUrl}` if (proxyOrigin) return `${proxyOrigin}/${hostBrokerUrl}`
if (LOCAL_HOSTNAMES.has(new URL(origin).hostname)) return `${FALLBACK_SANDBOX_PROXY_ORIGIN}/${hostBrokerUrl}` if (LOCAL_HOSTNAMES.has(new URL(origin).hostname)) return `${FALLBACK_SANDBOX_PROXY_ORIGIN}/${hostBrokerUrl}`
return hostBrokerUrl return hostBrokerUrl
+4 -5
View File
@@ -1,6 +1,6 @@
import { execFile, spawn } from "node:child_process" import { execFile, spawn } from "node:child_process"
import { promisify } from "node:util" import { promisify } from "node:util"
import { HOST_PATH, OPENCLAW_BIN, OPENSHELL_BIN } from "./hostCommands" import { HOST_PATH, OPENCLAW_BIN, OPENSHELL_BIN, hostCommandEnv } from "./hostCommands"
import { getDefaultOpenClawInstance, getOpenClawDashboardPortForSandbox, resolveOpenClawInstance } from "./openclawInstances" import { getDefaultOpenClawInstance, getOpenClawDashboardPortForSandbox, resolveOpenClawInstance } from "./openclawInstances"
const execFileAsync = promisify(execFile) const execFileAsync = promisify(execFile)
@@ -44,13 +44,12 @@ export type DashboardProbe = {
export async function execOpenShell(args: string[]) { export async function execOpenShell(args: string[]) {
const { stdout, stderr } = await execFileAsync(OPENSHELL_BIN, args, { const { stdout, stderr } = await execFileAsync(OPENSHELL_BIN, args, {
env: { env: hostCommandEnv({
...process.env, OPENSHELL_GATEWAY,
PATH: HOST_PATH,
NO_COLOR: "1", NO_COLOR: "1",
CLICOLOR: "0", CLICOLOR: "0",
CLICOLOR_FORCE: "0", CLICOLOR_FORCE: "0",
}, }),
}) })
return { stdout, stderr } return { stdout, stderr }
} }
+24
View File
@@ -61,6 +61,30 @@ export async function buildSandboxMcpBrokerHandoff(
token, token,
"```", "```",
"", "",
"## Quick Check",
"",
"Run this inside the sandbox to verify that you are using the current broker token without pasting it into your shell history:",
"",
"```sh",
"node - <<'NODE'",
"const fs = require('fs')",
`const url = ${JSON.stringify(`${brokerBaseUrl}/mcp`)}`,
"const manifest = fs.readFileSync('/sandbox/openshell_control_mcp.md', 'utf8')",
"const token = manifest.match(/```\\n(osmcp_[^\\n]+)\\n```/)?.[1]",
"if (!token) throw new Error('MCP broker token not found in /sandbox/openshell_control_mcp.md')",
"const payload = { jsonrpc: '2.0', id: 1, method: 'tools/list', params: {} }",
"fetch(url, {",
" method: 'POST',",
" headers: { 'content-type': 'application/json', authorization: `Bearer ${token}` },",
" body: JSON.stringify(payload),",
"})",
" .then(async (response) => {",
" const body = await response.json()",
" console.log(JSON.stringify({ status: response.status, tools: body.result?.tools?.map((tool) => tool.name) || [], error: body.error || null }, null, 2))",
" })",
"NODE",
"```",
"",
"## Rules", "## Rules",
"", "",
"- Do not assume any MCP server exists unless the broker returns it as available.", "- Do not assume any MCP server exists unless the broker returns it as available.",
+47 -9
View File
@@ -75,12 +75,40 @@ function parseNetworkRules(output: string): SandboxNetworkRule[] {
.filter((rule) => rule.chunkId) .filter((rule) => rule.chunkId)
} }
function hostPortForUrl(parsed: URL) {
const port = parsed.port || (parsed.protocol === "https:" ? "443" : "80")
return `${parsed.hostname}:${port}`
}
function addEndpointCandidate(candidates: Set<string>, parsed: URL) {
const hostPort = hostPortForUrl(parsed)
candidates.add(hostPort)
if (parsed.hostname === "host.docker.internal") {
const port = parsed.port || (parsed.protocol === "https:" ? "443" : "80")
candidates.add(`0.0.0.0:${port}`)
}
}
function extractProxiedTargetUrl(brokerBaseUrl: string) {
try {
const parsed = new URL(brokerBaseUrl)
const rawPath = parsed.pathname.replace(/^\/+/, "")
const decodedPath = decodeURIComponent(rawPath)
if (!/^https?:\/\//i.test(decodedPath)) return null
return new URL(decodedPath)
} catch {
return null
}
}
function brokerEndpointCandidates(brokerBaseUrl: string) { function brokerEndpointCandidates(brokerBaseUrl: string) {
const parsed = new URL(brokerBaseUrl) const parsed = new URL(brokerBaseUrl)
const port = parsed.port || (parsed.protocol === "https:" ? "443" : "80") const candidates = new Set<string>()
const hostPort = `${parsed.hostname}:${port}` addEndpointCandidate(candidates, parsed)
const candidates = new Set([hostPort])
if (parsed.hostname === "host.docker.internal") candidates.add(`0.0.0.0:${port}`) const proxiedTarget = extractProxiedTargetUrl(brokerBaseUrl)
if (proxiedTarget) addEndpointCandidate(candidates, proxiedTarget)
return candidates return candidates
} }
@@ -153,13 +181,23 @@ async function probeBrokerEndpoint(sandboxName: string, brokerBaseUrl: string) {
} }
const script = [ const script = [
"node", "node",
"--input-type=module",
"-e", "-e",
` `
fetch(${JSON.stringify(mcpUrl)}, { const controller = new AbortController();
method: "POST", const timeout = setTimeout(() => controller.abort(), 8000);
headers: { "content-type": "application/json" }, try {
body: ${JSON.stringify(JSON.stringify(payload))}, await fetch(${JSON.stringify(mcpUrl)}, {
}).catch(() => {}); method: "POST",
headers: { "content-type": "application/json" },
body: ${JSON.stringify(JSON.stringify(payload))},
signal: controller.signal,
});
} catch {
// The probe only exists to let OpenShell create a policy chunk.
} finally {
clearTimeout(timeout);
}
`, `,
] ]
await runOpenShell(["sandbox", "exec", "-n", sandboxName, "--", ...script], 15000).catch(() => null) await runOpenShell(["sandbox", "exec", "-n", sandboxName, "--", ...script], 15000).catch(() => null)
+7
View File
@@ -403,6 +403,10 @@ NEXT_PUBLIC_API_BASE=/api
NEXT_PUBLIC_ENABLE_SANDBOX_OPERATIONS=true NEXT_PUBLIC_ENABLE_SANDBOX_OPERATIONS=true
OPEN_SHELL_CONTAINER=${OPEN_SHELL_CONTAINER_DEFAULT} OPEN_SHELL_CONTAINER=${OPEN_SHELL_CONTAINER_DEFAULT}
OPENSHELL_GATEWAY=nemoclaw OPENSHELL_GATEWAY=nemoclaw
# For containerized CLI runs, when supported by the installed OpenShell/NemoClaw versions:
# OPENSHELL_GATEWAY_HOST=host.docker.internal
# OPENSHELL_GATEWAY_PORT=8080
# OPENSHELL_GATEWAY_URL=http://host.docker.internal:8080
EOF EOF
else else
log "Keeping existing $ENV_FILE" log "Keeping existing $ENV_FILE"
@@ -413,6 +417,9 @@ upsert_env "NEXT_PUBLIC_API_BASE" "/api"
upsert_env "NEXT_PUBLIC_ENABLE_SANDBOX_OPERATIONS" "true" upsert_env "NEXT_PUBLIC_ENABLE_SANDBOX_OPERATIONS" "true"
upsert_env "OPEN_SHELL_CONTAINER" "$OPEN_SHELL_CONTAINER_DEFAULT" upsert_env "OPEN_SHELL_CONTAINER" "$OPEN_SHELL_CONTAINER_DEFAULT"
upsert_env "OPENSHELL_GATEWAY" "nemoclaw" upsert_env "OPENSHELL_GATEWAY" "nemoclaw"
set_env "OPENSHELL_GATEWAY_HOST" "${OPENSHELL_GATEWAY_HOST:-}"
set_env "OPENSHELL_GATEWAY_PORT" "${OPENSHELL_GATEWAY_PORT:-}"
set_env "OPENSHELL_GATEWAY_URL" "${OPENSHELL_GATEWAY_URL:-}"
set_env "OPENSHELL_CONTROL_VENV" "${VIRTUAL_ENV:-$PROJECT_VENV}" set_env "OPENSHELL_CONTROL_VENV" "${VIRTUAL_ENV:-$PROJECT_VENV}"
set_env "OPENSHELL_HOME" "${HOME:-}" set_env "OPENSHELL_HOME" "${HOME:-}"
set_env "OPENSHELL_BIN" "${OPENSHELL_BIN:-}" set_env "OPENSHELL_BIN" "${OPENSHELL_BIN:-}"
+3
View File
@@ -54,6 +54,9 @@ Environment overrides:
NEMOCLAW_NON_INTERACTIVE NEMOCLAW_NON_INTERACTIVE
NEMOCLAW_EXPERIMENTAL NEMOCLAW_EXPERIMENTAL
NEMOCLAW_PROVIDER NEMOCLAW_PROVIDER
OPENSHELL_GATEWAY_HOST
OPENSHELL_GATEWAY_PORT
OPENSHELL_GATEWAY_URL
NVIDIA_API_KEY NVIDIA_API_KEY
EOF EOF
} }
+9
View File
@@ -115,6 +115,8 @@ assert.match(manifestSource, /syncSandboxMcpManifest/, 'MCP sandbox manifest mus
assert.match(manifestSource, /writeSandboxFilePrivileged/, 'MCP sandbox manifest must use a privileged write path for root-owned /sandbox mounts') assert.match(manifestSource, /writeSandboxFilePrivileged/, 'MCP sandbox manifest must use a privileged write path for root-owned /sandbox mounts')
assert.match(manifestSource, /syncSandboxOpenClawMcpConfig/, 'MCP sandbox manifest sync must also configure OpenClaw MCP') assert.match(manifestSource, /syncSandboxOpenClawMcpConfig/, 'MCP sandbox manifest sync must also configure OpenClaw MCP')
assert.match(manifestSource, /\/mcp/, 'MCP sandbox handoff must include the protocol-compatible MCP endpoint') assert.match(manifestSource, /\/mcp/, 'MCP sandbox handoff must include the protocol-compatible MCP endpoint')
assert.match(manifestSource, /Quick Check/, 'MCP sandbox handoff must include a token-safe local verification snippet')
assert.match(manifestSource, /tools\/list/, 'MCP sandbox handoff quick check should verify tool discovery')
assert.match(privilegedFilesSource, /kubectl/, 'privileged sandbox file writes must use the OpenShell cluster control path') assert.match(privilegedFilesSource, /kubectl/, 'privileged sandbox file writes must use the OpenShell cluster control path')
assert.doesNotMatch(manifestSource, /allowedServers|renderServer|commandLine/, 'MCP sandbox handoff must not disclose server inventory or launch specs') assert.doesNotMatch(manifestSource, /allowedServers|renderServer|commandLine/, 'MCP sandbox handoff must not disclose server inventory or launch specs')
assert.match(manifestSource, /control plane enforces/, 'MCP sandbox handoff must explain broker-side enforcement') assert.match(manifestSource, /control plane enforces/, 'MCP sandbox handoff must explain broker-side enforcement')
@@ -135,6 +137,8 @@ assert.match(sandboxMcpRouteSource, /brokerBaseUrlForSandbox/, 'Sandbox MCP brok
assert.match(sandboxMcpRouteSource, /synced\.openClaw\.path/, 'Sandbox MCP sync response must report the OpenClaw config write') assert.match(sandboxMcpRouteSource, /synced\.openClaw\.path/, 'Sandbox MCP sync response must report the OpenClaw config write')
assert.match(brokerUrlSource, /discoverOpenShellDockerGateway/, 'Sandbox MCP broker handoff must discover the active OpenShell network gateway') assert.match(brokerUrlSource, /discoverOpenShellDockerGateway/, 'Sandbox MCP broker handoff must discover the active OpenShell network gateway')
assert.match(brokerUrlSource, /LOCAL_HOSTNAMES/, 'Sandbox MCP broker handoff must rewrite local-only browser origins') assert.match(brokerUrlSource, /LOCAL_HOSTNAMES/, 'Sandbox MCP broker handoff must rewrite local-only browser origins')
assert.match(brokerUrlSource, /shouldUseProxyWrappedBrokerUrl/, 'Sandbox MCP broker handoff must make proxy-wrapped URLs opt-in')
assert.match(brokerUrlSource, /if \(!shouldUseProxyWrappedBrokerUrl\(\)\) return hostBrokerUrl/, 'Sandbox MCP broker handoff must prefer the direct gateway URL by default')
assert.match(brokerUrlSource, /discoverSandboxProxyOrigin/, 'Sandbox MCP broker handoff must discover each sandbox proxy endpoint') assert.match(brokerUrlSource, /discoverSandboxProxyOrigin/, 'Sandbox MCP broker handoff must discover each sandbox proxy endpoint')
assert.match(brokerUrlSource, /HTTP_PROXY/, 'Sandbox MCP broker handoff must derive the proxy endpoint from sandbox environment') assert.match(brokerUrlSource, /HTTP_PROXY/, 'Sandbox MCP broker handoff must derive the proxy endpoint from sandbox environment')
assert.match(brokerUrlSource, /FALLBACK_SANDBOX_PROXY_ORIGIN/, 'Sandbox MCP broker handoff may keep a fallback for older OpenShell layouts') assert.match(brokerUrlSource, /FALLBACK_SANDBOX_PROXY_ORIGIN/, 'Sandbox MCP broker handoff may keep a fallback for older OpenShell layouts')
@@ -143,6 +147,11 @@ assert.match(sandboxOpenClawMcpConfigSource, /streamable-http/, 'OpenClaw MCP br
assert.match(sandboxOpenClawMcpConfigSource, /Authorization: `Bearer \$\{token\}`/, 'OpenClaw MCP broker config must pass the sandbox broker token as bearer auth') assert.match(sandboxOpenClawMcpConfigSource, /Authorization: `Bearer \$\{token\}`/, 'OpenClaw MCP broker config must pass the sandbox broker token as bearer auth')
assert.match(sandboxOpenClawMcpConfigSource, /restartOpenClawGatewayIfRunning/, 'OpenClaw gateway must restart after MCP config changes') assert.match(sandboxOpenClawMcpConfigSource, /restartOpenClawGatewayIfRunning/, 'OpenClaw gateway must restart after MCP config changes')
assert.match(sandboxPermissionsSource, /method: "initialize"[\s\S]*method: "POST"/, 'MCP broker network sync must probe the actual streamable HTTP POST initialize path') assert.match(sandboxPermissionsSource, /method: "initialize"[\s\S]*method: "POST"/, 'MCP broker network sync must probe the actual streamable HTTP POST initialize path')
assert.match(sandboxPermissionsSource, /"--input-type=module"/, 'MCP broker network sync probe must support top-level await')
assert.match(sandboxPermissionsSource, /await fetch\(/, 'MCP broker network sync probe must wait for the policy-generating request')
assert.match(sandboxPermissionsSource, /extractProxiedTargetUrl/, 'MCP broker network sync must inspect proxy-wrapped target URLs')
assert.match(sandboxPermissionsSource, /const proxiedTarget = extractProxiedTargetUrl\(brokerBaseUrl\)/, 'MCP broker network sync must derive the target host behind the sandbox HTTP proxy')
assert.match(sandboxPermissionsSource, /if \(proxiedTarget\) addEndpointCandidate\(candidates, proxiedTarget\)/, 'MCP broker network sync must approve the proxied broker target host')
assert.match(middlewareSource, /\/api\/mcp\/broker/, 'MCP broker endpoints must bypass dashboard cookie auth and rely on broker token auth') assert.match(middlewareSource, /\/api\/mcp\/broker/, 'MCP broker endpoints must bypass dashboard cookie auth and rely on broker token auth')
assert.match(routeSource, /export async function GET/, 'MCP API must list server configuration') assert.match(routeSource, /export async function GET/, 'MCP API must list server configuration')
assert.match(routeSource, /export async function POST/, 'MCP API must install and update server configuration') assert.match(routeSource, /export async function POST/, 'MCP API must install and update server configuration')
@@ -0,0 +1,50 @@
import assert from 'node:assert/strict'
import { readFile } from 'node:fs/promises'
import path from 'node:path'
const root = process.cwd()
const proxyPath = path.join(root, 'app/api/openshell/dashboard/proxy/shared.ts')
const proxySource = await readFile(proxyPath, 'utf8')
assert.match(
proxySource,
/const pageGatewayUrl = protocol \+ '\/\/' \+ window\.location\.host \+ proxyPrefix/,
'dashboard bootstrap should know the same-origin websocket gateway scope'
)
assert.match(
proxySource,
/const sidecarGatewayUrl = protocol \+ '\/\/' \+ sidecarHost \+ proxyPrefix/,
'dashboard bootstrap should know the dedicated websocket sidecar gateway scope'
)
assert.match(
proxySource,
/const gatewayUrl = \(hashParams\.get\('gatewayUrl'\) \|\| ''\)\.trim\(\) \|\| sidecarGatewayUrl/,
'dashboard bootstrap should honor the tokenized launch gateway URL'
)
assert.match(
proxySource,
/const settingsPrefix = 'openclaw\.control\.settings\.v1:';/,
'dashboard bootstrap should write OpenClaw scoped settings'
)
assert.match(
proxySource,
/const gatewayScopes = uniqueScopes\(\[gatewayUrl, sidecarGatewayUrl, pageGatewayUrl\]\)/,
'dashboard bootstrap should seed token scopes for launch, sidecar, and page gateways'
)
assert.match(
proxySource,
/for \(const key of settingsKeys\) window\.localStorage\.setItem\(key, serializedSettings\)/,
'dashboard bootstrap should write settings to all gateway-scoped keys'
)
assert.match(
proxySource,
/for \(const scope of gatewayScopes\) window\.sessionStorage\.setItem\(tokenPrefix \+ scope, token\)/,
'dashboard bootstrap should write the OpenClaw token to every gateway scope'
)
assert.doesNotMatch(
proxySource,
/const tokenScope = gatewayUrl/,
'dashboard bootstrap must not restrict the token to only one gateway scope'
)
console.log('openclaw-dashboard-bootstrap-token-scope-check: PASS dashboard bootstrap token scope assertions')
+2 -1
View File
@@ -95,7 +95,8 @@ assert.match(createRouteSource, /mode: "legacy-setup"/, 'NemoClaw blueprint crea
assert.match(createRouteSource, /NemoClaw CLI was not found/, 'missing current CLI must produce an actionable error') assert.match(createRouteSource, /NemoClaw CLI was not found/, 'missing current CLI must produce an actionable error')
assert.match(createRouteSource, /NEMOCLAW_BIN_CANDIDATES\.join/, 'missing current CLI error must list searched candidates') assert.match(createRouteSource, /NEMOCLAW_BIN_CANDIDATES\.join/, 'missing current CLI error must list searched candidates')
assert.match(createRouteSource, /from "@\/app\/lib\/hostCommands"/, 'create route must use shared command resolution') assert.match(createRouteSource, /from "@\/app\/lib\/hostCommands"/, 'create route must use shared command resolution')
assert.match(deleteRouteSource, /NEMOCLAW_CWD/, 'delete route must use resolved NemoClaw working directory') assert.match(deleteRouteSource, /hostCommandEnv/, 'delete route must use shared host command environment')
assert.doesNotMatch(deleteRouteSource, /NEMOCLAW_CWD|NEMOCLAW_BIN/, 'delete route must not launch NemoClaw cleanup after OpenShell deletion')
for (const [label, source] of [ for (const [label, source] of [
['telemetry', telemetrySource], ['telemetry', telemetrySource],
+25 -3
View File
@@ -60,8 +60,17 @@ assert.match(
'blueprint create response must expose readiness polling metadata', 'blueprint create response must expose readiness polling metadata',
) )
assert.match(createRouteSource, /"onboard", "--non-interactive", "--recreate-sandbox"/, 'blueprint create must use the Monday-era normal NemoClaw onboard flow') assert.match(createRouteSource, /"onboard", "--non-interactive", "--recreate-sandbox"/, 'blueprint create must use the Monday-era normal NemoClaw onboard flow')
assert.doesNotMatch(createRouteSource, /"--from"|resolvePreferredNemoClawDockerfile|prepareDashboardOwnedNemoClawDockerfile/, 'blueprint create must not force the explicit Dockerfile path') assert.doesNotMatch(createRouteSource, /resolvePreferredNemoClawDockerfile|prepareDashboardOwnedNemoClawDockerfile/, 'blueprint create must not force the explicit Dockerfile path')
assert.match(createRouteSource, /NEMOCLAW_SANDBOX_NAME: sandboxName/, 'blueprint create must pass the requested sandbox name to NemoClaw onboarding') assert.match(createRouteSource, /NEMOCLAW_SANDBOX_NAME: sandboxName/, 'blueprint create must pass the requested sandbox name to NemoClaw onboarding')
assert.match(createRouteSource, /id: "redeploy-image"/, 'create API must expose image redeploy as a sandbox creation path')
assert.match(createRouteSource, /label: "Quick Deploy New NemoClaw Sandbox"/, 'image redeploy must be labeled as the quick deploy default path')
assert.match(createRouteSource, /label: "Fresh NemoClaw Image"/, 'full rebuild path must be labeled as fresh image creation')
assert.match(createRouteSource, /readNemoClawRegistry/, 'image redeploy must discover the default NemoClaw sandbox image automatically')
assert.match(createRouteSource, /listOpenShellSandboxNames/, 'image redeploy must fall back to live OpenShell inventory when registry entries are stale')
assert.match(createRouteSource, /resolveSourcePodImage\(sourceSandboxName, sandboxName\)/, 'image redeploy must allow optional explicit source while defaulting automatically')
assert.match(createRouteSource, /"--from",\s*sourceImage/, 'image redeploy must pass the resolved image to openshell sandbox create')
assert.match(createRouteSource, /"--auto-providers"/, 'image redeploy must use OpenShell auto providers for provider-backed images')
assert.match(createRouteSource, /registerNemoClawImageRedeploy/, 'image redeploy must register the new sandbox without a full NemoClaw rebuild')
assert.match(createRouteSource, /const requestedMode = typeof raw\.mode === "string" \? raw\.mode : "vllm"/, 'blueprint create must default to vLLM experimental onboarding when the UI payload is absent') assert.match(createRouteSource, /const requestedMode = typeof raw\.mode === "string" \? raw\.mode : "vllm"/, 'blueprint create must default to vLLM experimental onboarding when the UI payload is absent')
assert.match(createRouteSource, /NEMOCLAW_EXPERIMENTAL = "1"/, 'blueprint create must support NemoClaw experimental provider onboarding') assert.match(createRouteSource, /NEMOCLAW_EXPERIMENTAL = "1"/, 'blueprint create must support NemoClaw experimental provider onboarding')
assert.match(createRouteSource, /NEMOCLAW_PROVIDER = "vllm"/, 'blueprint create must support the vLLM onboarding provider') assert.match(createRouteSource, /NEMOCLAW_PROVIDER = "vllm"/, 'blueprint create must support the vLLM onboarding provider')
@@ -105,9 +114,20 @@ assert.match(deleteRouteSource, /resolveSandboxRef/, 'delete route must resolve
assert.match(deleteRouteSource, /OPENSHELL_GATEWAY: process\.env\.OPENSHELL_GATEWAY \|\| "nemoclaw"/, 'delete route must use the NemoClaw gateway context') assert.match(deleteRouteSource, /OPENSHELL_GATEWAY: process\.env\.OPENSHELL_GATEWAY \|\| "nemoclaw"/, 'delete route must use the NemoClaw gateway context')
assert.match(hostCommandsSource, /export function hostCommandEnv/, 'host commands must provide a shared environment for OpenShell child processes') assert.match(hostCommandsSource, /export function hostCommandEnv/, 'host commands must provide a shared environment for OpenShell child processes')
assert.match(hostCommandsSource, /XDG_CONFIG_HOME/, 'shared host command environment must preserve the OpenShell config home') assert.match(hostCommandsSource, /XDG_CONFIG_HOME/, 'shared host command environment must preserve the OpenShell config home')
assert.match(hostCommandsSource, /export function openshellGatewayAddressEnv/, 'shared host command environment must expose gateway address override variables')
assert.match(hostCommandsSource, /OPENSHELL_GATEWAY_HOST/, 'shared host command environment must pass a configurable gateway host to child processes')
assert.match(hostCommandsSource, /OPENSHELL_GATEWAY_PORT/, 'shared host command environment must pass a configurable gateway port to child processes')
assert.match(hostCommandsSource, /OPENSHELL_GATEWAY_URL/, 'shared host command environment must pass or synthesize a gateway URL for child processes')
assert.match(hostCommandsSource, /gateway\.json/, 'shared host command environment must read gateway address config from the OpenShell config directory')
assert.match(hostCommandsSource, /config\.json/, 'shared host command environment must also support the general OpenShell config file')
assert.match(hostCommandsSource, /gatewayHost/, 'OpenShell gateway address config must support a top-level gatewayHost key')
assert.match(hostCommandsSource, /gateway\.host/, 'OpenShell gateway address config must support a nested gateway host key')
assert.match(createRouteSource, /const env: NodeJS\.ProcessEnv = hostCommandEnv\(\{[\s\S]*NEMOCLAW_SANDBOX_NAME: sandboxName[\s\S]*OPENSHELL_GATEWAY: process\.env\.OPENSHELL_GATEWAY \|\| "nemoclaw"/, 'NemoClaw onboard must receive the shared host command environment')
assert.match(deleteRouteSource, /env: hostCommandEnv\(\{[\s\S]*OPENSHELL_GATEWAY: process\.env\.OPENSHELL_GATEWAY \|\| "nemoclaw"/, 'delete route must pass the shared host command environment to OpenShell')
assert.match(deleteRouteSource, /waitForSandboxDeleted/, 'delete route must poll authoritative inventory until the sandbox is gone') assert.match(deleteRouteSource, /waitForSandboxDeleted/, 'delete route must poll authoritative inventory until the sandbox is gone')
assert.match(deleteRouteSource, /cleanupNemoClawSandbox/, 'delete route must clean up NemoClaw registry state after deleting from OpenShell') assert.doesNotMatch(deleteRouteSource, /cleanupNemoClawSandbox/, 'delete route must not run NemoClaw destroy cleanup after OpenShell deletion')
assert.match(deleteRouteSource, /\[sandboxName, "destroy", "--yes"\]/, 'delete route must match the Monday-era NemoClaw destroy cleanup path') assert.doesNotMatch(deleteRouteSource, /isNemoClawSandboxNotRegistered/, 'delete route must not keep NemoClaw registry cleanup helpers')
assert.doesNotMatch(deleteRouteSource, /\[sandboxName, "destroy", "--yes"\]/, 'delete route must not call nemoclaw destroy because it can delete the gateway')
assert.doesNotMatch(deleteRouteSource, /Pruned NemoClaw registry entry without destroying the shared OpenShell gateway|cleanupGatewayAfterLastSandbox/, 'delete route must not include the later registry-prune rewrite') assert.doesNotMatch(deleteRouteSource, /Pruned NemoClaw registry entry without destroying the shared OpenShell gateway|cleanupGatewayAfterLastSandbox/, 'delete route must not include the later registry-prune rewrite')
assert.match(deleteRouteSource, /openShellAlreadyGone/, 'delete route must tolerate sandboxes that OpenShell already deleted while NemoClaw still has registry state') assert.match(deleteRouteSource, /openShellAlreadyGone/, 'delete route must tolerate sandboxes that OpenShell already deleted while NemoClaw still has registry state')
assert.doesNotMatch(deleteRouteSource, /isGatewayRecoverable|recoverableGateway/, 'delete route must not include the later gateway-repair branching') assert.doesNotMatch(deleteRouteSource, /isGatewayRecoverable|recoverableGateway/, 'delete route must not include the later gateway-repair branching')
@@ -181,5 +201,7 @@ assert.doesNotMatch(configPanelSource, /onInventoryRefresh/, 'create panel must
assert.match(configPanelSource, /Use vLLM in experimental mode/, 'create panel must expose vLLM experimental onboarding') assert.match(configPanelSource, /Use vLLM in experimental mode/, 'create panel must expose vLLM experimental onboarding')
assert.match(configPanelSource, /Use NVIDIA NIM/, 'create panel must expose NVIDIA NIM onboarding') assert.match(configPanelSource, /Use NVIDIA NIM/, 'create panel must expose NVIDIA NIM onboarding')
assert.match(configPanelSource, /createInference/, 'create panel must send create-time inference settings') assert.match(configPanelSource, /createInference/, 'create panel must send create-time inference settings')
assert.match(configPanelSource, /useState<string>\('redeploy-image'\)/, 'create panel must default to quick deploy')
assert.doesNotMatch(configPanelSource, /Source Sandbox|sourceSandboxName/, 'basic create panel must not require choosing a source image')
console.log('sandbox-lifecycle-check: PASS create/destroy lifecycle assertions') console.log('sandbox-lifecycle-check: PASS create/destroy lifecycle assertions')